Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4180/3/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: Line 293: unique_ptr<Action> add_server = > There's no sorting in Action::BuildHelp() or Mode::BuildHelp(). But aren't Ok, although I suggested the ordering earlier, my second thoughts were like - really they are variable names after all, and no point in alphabetically sorting them in the source. Help display is the one which matters I guess. http://gerrit.cloudera.org:8080/#/c/4180/4/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: PS4, Line 117: tablet_raw > I'm not aware of a way to "offer" the internal pointer stored by the unique Hmmm, I saw your other patch here is addressing the actual method https://gerrit.cloudera.org/#/c/4179/ My Qn was why couldn't we change the method to accept unique_ptr<KuduTablet>* tablet_out ? Apart from the basic ownership differences, I am very much in the dark what should be used where TBH. Line 204: return ChangeConfig(context, consensus::REMOVE_SERVER); > Check out L186: the cc_type is stored directly in the ChangeConfigRequestPB Got it, thanks. -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
