Jordan Birdsell has posted comments on this change. Change subject: KUDU-1304 - [python] Enable listing of tablet servers ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4328/2/python/kudu/client.pyx File python/kudu/client.pyx: PS2, Line 368: ts = TabletServer() : result.append(ts._init(tservers[i]) > I assume this 'init' thing is because it's not possible to do a normal __in Yep, annoying, seemed like the only other option was to deconstruct/reconstruct the class altogether but that seemed like a worse idea. PS2, Line 499: Repres > typo Done PS2, Line 500: TabletSe > expand out the abbreviation here 'TabletServers' Done PS2, Line 507: _init > does this show up as a method in the generated python class? If so, maybe i Done Line 510: > I think we need some __dealloc__ here which takes care of deleting _tserver Done -- To view, visit http://gerrit.cloudera.org:8080/4328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
