Mike Percy has posted comments on this change. Change subject: KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting ......................................................................
Patch Set 1: Code-Review+1 (1 comment) lgtm http://gerrit.cloudera.org:8080/#/c/4333/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1362: // our vote. > nit: no need to wrap I personally prefer wrapping comments at 80 chars unless there is a reason not to, and that's what I usually do. It's slightly easier to read. But 80 chars is often too short for code... -- To view, visit http://gerrit.cloudera.org:8080/4333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecc55bc9e96dcdc918ede1190b7cbac719f95506 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
