Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC ......................................................................
Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/19/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 704: *ancient_history_mark = HybridClock::AddPhysicalTimeToTimestamp(clock_->Now(), neg_hist_age); > Duh, yeah. Still OK: still think the math's wrong, because you're subtracting 2**31*1000000 from the hybrid timestamp rather than its physical portion. Here's proof in the form of a faiing unit test: TEST_F(HybridClockTest, TestClockCanSubtractMaxSignedIntSeconds) { Timestamp now = clock_->Now(); Timestamp before = HybridClock::AddPhysicalTimeToTimestamp( now, MonoDelta::FromSeconds(std::numeric_limits<int32_t>::min())); ASSERT_EQ(before.CompareTo(now), -1); } -- To view, visit http://gerrit.cloudera.org:8080/3076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9833a863f118eb82be80ea56204d0d9141611c2 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
