Todd Lipcon has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3974/9/build-support/lint.sh File build-support/lint.sh: Line 54: --filter=-whitespace/comments,-readability/todo,-readability/inheritance,-build/header_guard,-build/include_order,-legal/copyright,-build/c++11 \ hrm, why turn off this lint warning? is it just a bogus warning? (http://en.cppreference.com/w/cpp/language/final seems to indicate that 'final' and 'virtual' should come together, but lint is complaining?) Should we file a bug against cpplint.py? -- To view, visit http://gerrit.cloudera.org:8080/3974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62256168a9245c845e99f7253f07e69a225954bf Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes