Adar Dembo has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/4305/9/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: PS9, Line 679: tablet > yikes !! sorry, actually it's kinda odd that all our required params are 't Well, I think "tablet_id" does make more sense than something like "replica_id", because the identifier is unique to the tablet rather than to the replica. That is, all replicas of this tablet share this same identifier, so it is not a useful way of identifying this replica. And yes, we should still wrap at 80 chars; I'm not sure how this thread suggests otherwise? http://gerrit.cloudera.org:8080/#/c/4305/12/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: PS12, Line 676: Nit: should be "local Kudu replica" to be consistent with the description of the local_replica mode. -- To view, visit http://gerrit.cloudera.org:8080/4305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ec628b65613011d8c48b6239c13762276425966 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
