David Ribeiro Alves has posted comments on this change. Change subject: [client] performance optimizations ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4385/2/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: Line 481 > Not sure I can track that condition in the ctor or caller of the ctor if no yeah my suggestion wouldn't work, I don't feel strongly and won't mind if you remove it. My read of it though is the following, fwiw: it would be nice to warn users when a timeout is not set, but since we can't do it only once without adding a var lets do it every 1000 batches. maybe then it'll be annoying enough that users do it :) -- To view, visit http://gerrit.cloudera.org:8080/4385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
