Alexey Serbin has posted comments on this change. Change subject: [client-test] faster TestFlushModesCompareOpRates* ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4437/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS1, Line 2269: ASSERT_OK(session->SetMutationBufferFlushWatermark(0.5)); : ASSERT_OK(session->SetMutationBufferMaxNum(2)); > Aren't these the default values? Yes, they are. My concern was to have this test working even if we change the defaults. If changing flush watermark, the margin becomes thinner. BTW, I started thinking about removing these two tests at all. :) >From one side, it's good to have a test which verifies that >AUTO_FLUSH_BACKGROUND works faster because it does not incur penalty for >flushing every single write operation. From the other side, should it be a >unit test? What do you think? -- To view, visit http://gerrit.cloudera.org:8080/4437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
