David Ribeiro Alves has posted comments on this change. Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8 ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4495/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: PS1, Line 127: 2 > Need to change this to 3. yeah, my guess is that this wasn't a problem cuz no macOS jenkins PS1, Line 135: gperftools-add_get_default_zone_to_osx_libc_override > Maybe you can rename the patch so that it explicitly refers to the gperftoo makes sense. Done -- To view, visit http://gerrit.cloudera.org:8080/4495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
