Alexey Serbin has posted comments on this change.

Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4492/3/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

Line 2435:   const size_t kIterNum = AllowSlowTests() ? 1024 : 256;
> I apologize for not saying the first time around.
I should have asked for the driver for your request :)

Sure.  The essence of this test is to have explicit and background flushes run 
in parallel, having some contention sometimes and making sure no errors 
appears.  There is no need to insert a lot of rows -- in that sense there is no 
difference having huge or small buffers to flush.

Yes, I'll add a check to verify that rows have landed in the DB.


-- 
To view, visit http://gerrit.cloudera.org:8080/4492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bd5d248d4d44393689c8da81ed669395c393257
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

Reply via email to