Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Improve and hide OperationResponse#getWriteTimestamp ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-client/src/main/java/org/apache/kudu/client/OperationResponse.java File java/kudu-client/src/main/java/org/apache/kudu/client/OperationResponse.java: Line 81: * @return a long representing a HybridClock-encoded timestamp, > we call it hybridtime elsewhere. also iirc we actually always return the wr I'll change the HybridClock in AbstractKuduScannerBuilder too then. And it looks like you're right, the ts is always there. PS1, Line 85: @InterfaceAudience.Private > Should probably add this to the release notes for 1.1.0. Yeah, although I doubt anybody is using this. I can also change the method's name in a backward compatible way. -- To view, visit http://gerrit.cloudera.org:8080/4487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cfc6fcc1d0607a94bb8be9e5a0d53a4987920af Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
