Alexey Serbin has posted comments on this change. Change subject: [c++compilation] fixed 'unused' warnings ......................................................................
Patch Set 1: (1 comment) Oops, it seems I pressed 'Submit' instead of reply. Anyway, I'm definitely open to change it. http://gerrit.cloudera.org:8080/#/c/4503/1/src/kudu/codegen/row_projector.cc File src/kudu/codegen/row_projector.cc: PS1, Line 429: auto compat_check = [](const Schema& base1, const Schema& proj1, : const Schema& base2, const Schema& proj2) { > You find the use of a lambda to be cleaner than just surrounding the functi Well, for some reason I didn't feel comfortable putting it under ifdef. Besides, I didn't see any other places this method is used and there aren't any other analogous methods around. Probably, there might be some performance penalties. If you have additional reasons to move it under ifdef, I will definitely reconsider this. -- To view, visit http://gerrit.cloudera.org:8080/4503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0a59ef51e5c5ea8be89109a48a57dc5abfde646 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
