Jean-Daniel Cryans has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4491/2/java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java File java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java: Line 27: public class InsertIgnore extends Operation { As part of this patch or in a separate one, we should deprecate KuduSession#setIgnoreAllDuplicateRows and all that's related to it and tell folks to use InsertIgnore if they really want to ignore row errors. It used to be useful to set that parameter when we didn't have the replay cache but now it's not really an issue anymore. -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Brock Noland <br...@phdata.io> Gerrit-Reviewer: Brock Noland <br...@phdata.io> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
