Adar Dembo has posted comments on this change. Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1710: KuduScanBatch* Nit: in this case the argument is included in the string, in the others it's not. Why is that? http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/schema.h File src/kudu/client/schema.h: PS2, Line 88: explicit Isn't this only desirable for single-arg constructors? -- To view, visit http://gerrit.cloudera.org:8080/4529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
