Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4526/4//COMMIT_MSG Commit Message: Line 9: Created separate vectors for live and tombstone tablets based on their TabletDataState_Name. style nit: consider applying tip about generic git commit guidelines and practices mentioned at https://github.com/apache/kudu/blob/master/docs/contributing.adoc#submitting-patches http://gerrit.cloudera.org:8080/#/c/4526/4/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: PS4, Line 192: vector<scoped_refptr<TabletPeer> > Consider passing this by const reference: the code does not modify the contents of the peers containers; using reference allows to omit unnecessary copying the argument. -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
