Andrew Wong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4537

Change subject: KUDU-1651: Check empty dict before decoder eval
......................................................................

KUDU-1651: Check empty dict before decoder eval

A completely null dictionary-encoded column will yield an empty
dictionary. When decoder-level evaluation is on, this will result in
an error when creating the bitmap of matching codewords, as bitmaps
must have a non-zero size.

In this scenario, it is sufficient to not determine the set of
matching codewords. The decoder should be completely skipped over
given a null column, so the matching codeword set would not be used
here. If the decoder is not skipped over and an attempt is made to
read from the dictionary block, an error should be thrown.

Change-Id: I76d457c65238b3b2283d826076fdc7525d032e3f
---
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
3 files changed, 19 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/4537/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76d457c65238b3b2283d826076fdc7525d032e3f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <anjuw...@cs.ucla.edu>

Reply via email to