Adar Dembo has posted comments on this change. Change subject: [java-client] IN-list predicate ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4530/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java: PS2, Line 351: if (t instanceof Boolean) { Yessssss (AKA "thanks, type erasure") Line 392: checkColumn(column, Type.BINARY); Don't want to add the bytes? Or maybe this is http://www.snopes.com/music/artists/vanhalen.asp? -- To view, visit http://gerrit.cloudera.org:8080/4530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia556196963153f9db64d67bc699f96cb920ecac6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
