Adar Dembo has posted comments on this change. Change subject: thirdparty: use libc++ instead libstdc++ for TSAN builds ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4511/1//COMMIT_MSG Commit Message: PS1, Line 23: unsafe > not sure unsafe is the right term here- it just fails to link, right? Yeah, I'll reword. http://gerrit.cloudera.org:8080/#/c/4511/1/build-support/dist_test.py File build-support/dist_test.py: Line 66: "thirdparty/installed-deps/bin/llvm-symbolizer", > perhaps this should just use the clang-toolchain symlink? Can't; this code resolves symlinks and so we'll end up shipping a path like thirdparty/llvm-3.9.0.build/bin/... which isn't something that run-test.sh or run_dist_test.py expect. We could modify them to expect such a path, but then they'd need to be modified with each llvm upgrade, which is annoying. http://gerrit.cloudera.org:8080/#/c/4511/1/build-support/run-test.sh File build-support/run-test.sh: Line 101: export ASAN_SYMBOLIZER_PATH=$SOURCE_ROOT/thirdparty/installed-deps/bin/llvm-symbolizer > and likewise here, if that's what you choose. See earlier explanation. http://gerrit.cloudera.org:8080/#/c/4511/1/build-support/run_dist_test.py File build-support/run_dist_test.py: Line 131: env['ASAN_SYMBOLIZER_PATH'] = os.path.join(ROOT, "thirdparty/installed-deps/bin/llvm-symbolizer") > and here See earlier explanation. http://gerrit.cloudera.org:8080/#/c/4511/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 114: ./configure > What's the effect of this change? Should be a no-op; we're not running 'make install' so there's no point in setting --prefix. -- To view, visit http://gerrit.cloudera.org:8080/4511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9e68126ae21e04469053009c5b3e4b588415895 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
