Dan Burkert has posted comments on this change. Change subject: KUDU-1363: Add IN-list predicate type ......................................................................
Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/2986/18/src/kudu/common/column_predicate-test.cc File src/kudu/common/column_predicate-test.cc: Line 464: // = | | > nit: is this supposed to be Done Line 472: // <----) AND > Just in case, consider adding tests for boundary conditions like The equality ones are already tested in the equality + range section. I've added some additional tests to make sure single element lists get simplified to an equality. Added the rest. http://gerrit.cloudera.org:8080/#/c/2986/18/src/kudu/common/wire_protocol-test.cc File src/kudu/common/wire_protocol-test.cc: PS18, Line 357: ASSERT_EQ > Here and below for the ASSERT_EQ() macro: Done -- To view, visit http://gerrit.cloudera.org:8080/2986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598 Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sameer Abhyankar <abhyan...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sameer Abhyankar <abhyan...@gmail.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
