Adar Dembo has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4566/2/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: Line 590: default: LOG(FATAL) << "unknown predicate type"; Out of curiosity, does ToString() emit a warning too? If not, why not? -- To view, visit http://gerrit.cloudera.org:8080/4566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id34b3461164d96261e4a2d1657244332eb33ad0c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
