Dinesh Bhat has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/4551/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS2, Line 499: en to by another lbm, we must reinspect th > Sort of; the log block manager is careful to only write to the metadata fil Hmmm, makes sense, thanks. And how does compaction weigh in here ? i.e if compaction kicked in after the check (data_file_sz < record.details) and end up reducing the data_file_size even further ? I am not sure if that's possible or not or perhaps compaction results into writing to a new data file altogether so that situation doesn't arise here ? http://gerrit.cloudera.org:8080/#/c/4551/5/src/kudu/integration-tests/open-readonly-fs-itest.cc File src/kudu/integration-tests/open-readonly-fs-itest.cc: Line 30: using kudu::client::KuduColumnSchema; Unused ? Line 36: using kudu::client::KuduWriteOperation; Unused ? Ignore these comments since I don't trust gerrit searches sometimes Line 92: } 80-char wrap up ? -- To view, visit http://gerrit.cloudera.org:8080/4551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68b04f1f1b8cd099120a220b1245ecf8f422770 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
