Hello Jordan Birdsell, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4568
to review the following change.
Change subject: KuduPredicate::Clone on IN list predicate causes segfault
......................................................................
KuduPredicate::Clone on IN list predicate causes segfault
Jordan Birdsell uncovered this issue where a cloned IN list predicate
causes a segfault when applied to a scanner. During the clone, the
values list was being 'preallocated' using the vector(int) constructor,
which adds a bunch of default constructed values (in this case, nullptrs
since the type is const void*). We previously didn't have any test
coverage of the Clone method, so I added a check to every column
predicate test to make sure that scans with cloned predicates behave the
same as the original predicates. The test segfaults without the fix.
Change-Id: I977691390535273c37aa90c3a3663a7c09ea67fc
---
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_predicate-internal.h
2 files changed, 21 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/4568/1
--
To view, visit http://gerrit.cloudera.org:8080/4568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I977691390535273c37aa90c3a3663a7c09ea67fc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com>
