Alexey Serbin has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools ......................................................................
Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/4412/20/src/kudu/tools/tool_action_test.cc File src/kudu/tools/tool_action_test.cc: PS20, Line 401: supposed > Nit: "assumed", right? Done PS20, Line 405: // It's necessary to have read-what-you-write behavior here. Since : // tablet leader can change and there might be replica propagation delays, : // set the snapshot to the latest observed one to get correct row count. > As JD discovered with ITClient, if you end up scanning from a replica that OK, thanks for the info. I added retry logic for that. It looks uglier now, but it should do the job. -- To view, visit http://gerrit.cloudera.org:8080/4412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
