Adar Dembo has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone ......................................................................
Patch Set 1: (4 comments) Good find. http://gerrit.cloudera.org:8080/#/c/4594/1/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: Line 22: #include <cstdlib> What's this one for? Line 29: #include "kudu/gutil/strings/substitute.h" Not used? PS1, Line 133: <random> Why randomize the non-existent command? You can just hardcode some nonsensical string instead, and save some function calls/includes. PS1, Line 136: TestKUDU1674 You've already got the bug in the comment just above, so use the test name to describe the bug itself, or what the test is covering. -- To view, visit http://gerrit.cloudera.org:8080/4594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67bd462098526a9ba032669b621b8139b56ee5b8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
