Alexey Serbin has posted comments on this change. Change subject: [util] shorten names for key/mapped types ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4584/1/src/kudu/gutil/map-util.h File src/kudu/gutil/map-util.h: PS1, Line 35: // A note on terminology: : // : // Map-like containers are collections of pairs. Like all STL containers they : // contain a few standard typedefs identifying the types of data they contain. : // Given the following map declaration: : // : // map<string, int> my_map; : // : // the notable typedefs would be as follows: : // : // - key_type -- string : // - value_type -- pair<const string, int> : // - mapped_type -- int : // : // Note that the map above contains two types of "values": the key-value pairs : // themselves (value_type) and the values within the key-value pairs : // (mapped_type). A value_type consists of a key_type and a mapped_type. : // : // The documentation below is written for programmers thinking in terms of keys : // and the (mapped_type) values associated with a given key. For example, the : // statement > Does this need to be updated? As I can see, this piece contains valid and actual information. I could not see longer typenames here like value_type::first_type or value_type::second_type. So, I'd leave it as is if there aren't objections. -- To view, visit http://gerrit.cloudera.org:8080/4584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9126f9b9a4a2e227ded842eee85140f81051fba6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
