Hello Dinesh Bhat, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4599
to review the following change.
Change subject: Clean up switch statements in column_predicate.cc
......................................................................
Clean up switch statements in column_predicate.cc
Where possible, remove default branches in favor of LOG(FATAL) calls
outside the switch. This makes it more likely that the switch will be
updated in the future for new predicate types, since C++ compilers can
warn on incomplete switches if there is no default branch.
Also cleans up a confusing fall-through in ColumnPredicate::operator==.
Change-Id: I80b750f7bc7455607c380ca65744d8cc66eeabd1
---
M src/kudu/common/column_predicate.cc
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/4599/1
--
To view, visit http://gerrit.cloudera.org:8080/4599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80b750f7bc7455607c380ca65744d8cc66eeabd1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
