David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE ......................................................................
Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 688: nit extra space http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/client/write_op.h File src/kudu/client/write_op.h: PS8, Line 149: A single row insert ignore to be sent to the cluster ignored on duplicate row hum, this sentence reads weird. http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: Line 620: nit extra line http://gerrit.cloudera.org:8080/#/c/4491/7/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 365: // refer to INSERT IGNORE. It refers to inserts ignored during log replay > Is that true though? The `inserts_ignored` property existed before insert i nah, I don't know what I was thinking here. you're right. inserts_ignored in this context means the inserts we don't apply cuz they were already flushed to disk. this looks good. http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: PS8, Line 34: insert ignored Maybe this should be counting the number of errors that were ignored instead of the number of inserts that were marked as insert_ignore. I see that as more interesting from an operations perspective. What do you think? http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/tablet/transactions/transaction.h File src/kudu/tablet/transactions/transaction.h: Line 49: int successful_insert_ignores; does what I mentioned in the tablet metrics apply here? -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Brock Noland <br...@phdata.io> Gerrit-Reviewer: Brock Noland <br...@phdata.io> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
