David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1567. Decouple hard-minimum WAL segment retention from target ......................................................................
Patch Set 5: (3 comments) just nits really. looking good http://gerrit.cloudera.org:8080/#/c/4470/5/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 1642: replay_size_map); nit wrapping http://gerrit.cloudera.org:8080/#/c/4470/5/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: PS5, Line 271: op clears not in this patch, but can you fix this to: "the op that minimizes" or something. http://gerrit.cloudera.org:8080/#/c/4470/5/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: PS5, Line 347: FLAGS_log_target_replay_size_mb nit weird wrapping can you move this to the line above? -- To view, visit http://gerrit.cloudera.org:8080/4470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31400e2200f9ce3eeb63f4bc948bc630e8c1115f Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
