Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone ......................................................................
KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone ReadFdsFully() captures either stdout or stderr or both depending on how caller has registered. Once the helpers are done with capturing, it needs take into account that there can be less than 2 fds registered from the caller and hence can not do std::move(vector[1]) operation on it. Also added a test code to exercise combination of: SubProcess::Call({argv}, nullptr, &stderr); SubProcess::Call({argv}, &stdout, nullptr); SubProcess::Call({argv}, nullptr, nullptr); Change-Id: I67bd462098526a9ba032669b621b8139b56ee5b8 Reviewed-on: http://gerrit.cloudera.org:8080/4594 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <aser...@cloudera.com> --- M src/kudu/util/subprocess-test.cc M src/kudu/util/subprocess.cc 2 files changed, 28 insertions(+), 4 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67bd462098526a9ba032669b621b8139b56ee5b8 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins