Adar Dembo has posted comments on this change. Change subject: mem_tracker: fix race between FindTracker() and destructor ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4614/1/src/kudu/util/mem_tracker-test.cc File src/kudu/util/mem_tracker-test.cc: PS1, Line 348: num_runs > this variable seems poorly named. perhaps thread_idx? Well, my original intent here was to run the test 20 times for a shorter duration each time, rather than once for one second. Along the way I think I made some changes to use it to reproduce my bug too. But, I'm actually going to restore it to be the way it was, so that it's still very clearly the regression test for commit e284a93. I had no good reason to modify it the way I did, and the num_runs thing can be had via gtest_repeat anyway. -- To view, visit http://gerrit.cloudera.org:8080/4614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69610f782c7a00d161bfb48d2487c29c0309c985 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
