Todd Lipcon has submitted this change and it was merged. Change subject: maintenance_manager-test: fix flaky test ......................................................................
maintenance_manager-test: fix flaky test TestCompletedOps failed relatively often because of the following racy interleaving: - Multiple MM threads called Prepare() while remaining_runs_ was positive - These threads then called Perform(), which decremented remaining_runs_ once per thread. This resulted in the op being called more times than 'remaining_runs_', causing an assertion failure. The fix is to separately count the number of 'prepared' ops. Change-Id: I003e72339f69228195130c89572a20be3009f22c Reviewed-on: http://gerrit.cloudera.org:8080/4634 Reviewed-by: Jean-Daniel Cryans <jdcry...@apache.org> Tested-by: Kudu Jenkins --- M src/kudu/util/maintenance_manager-test.cc 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I003e72339f69228195130c89572a20be3009f22c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
