Alexey Serbin has posted comments on this change. Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4640/2/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: PS2, Line 144: if (PREDICT_FALSE(FLAGS_fail_dns_resolution)) { : return Status::NetworkError("injected DNS resolution failure"); : } Nit: does it make sense to move it before the for() cycle which populates the addresses output parameter? -- To view, visit http://gerrit.cloudera.org:8080/4640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
