Todd Lipcon has submitted this change and it was merged. Change subject: [flaky tests] Address SIGSEGV on ResultTracker while running alter_table_randomized-test ......................................................................
[flaky tests] Address SIGSEGV on ResultTracker while running alter_table_randomized-test This addresses a flakyness in the alter_table_randomized-test whereby calling ResultTracker::FailAndRespond() on a transaction that was never tracked (a legal and possible thing for follower transactions) would cause a SIGSEGV. The SIGSEGV is caused because we try to deference the CompletionRecord* to track its memory, even though we already know it doesn't exist. This is hard to reproduce in either exactly once tests, but the change is pretty obvious. I also added some comment on how that can happen, it took me a while to find the path that could cause this (again). Change-Id: I961af334fa2dd7faff0e95c7a49f2f16b2096fe0 Reviewed-on: http://gerrit.cloudera.org:8080/4629 Reviewed-by: Dan Burkert <d...@cloudera.com> Tested-by: David Ribeiro Alves <dral...@apache.org> Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/rpc/result_tracker.cc 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Dan Burkert: Looks good to me, but someone else must approve David Ribeiro Alves: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961af334fa2dd7faff0e95c7a49f2f16b2096fe0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
