Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE ......................................................................
Patch Set 8: (17 comments) Updated patch should have these items addressed. http://gerrit.cloudera.org:8080/#/c/4491/8//COMMIT_MSG Commit Message: PS8, Line 9: Add's > nit: adds Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS8, Line 1847: insertIgnore > nit (here and elsewhere below): should be 'insert_ignore', not camelCase in Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 688: > nit extra space Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/client/write_op.h File src/kudu/client/write_op.h: PS8, Line 149: A single row insert ignore to be sent to the cluster ignored on duplicate row > hum, this sentence reads weird. Done PS8, Line 151: insert ignore > capitalize INSERT IGNORE Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/common/row_operations-test.cc File src/kudu/common/row_operations-test.cc: Line 129: enc.Add(RowOperationsPB::INCLUSIVE_RANGE_UPPER_BOUND, row); > missing a 'break' here. Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: Line 319: ops->push_back({TEST_INSERT_IGNORE, row_key}); > nit: funny indentation Done Line 321: ops_pending = false; > ops_pending should be true either way (since there is something to flush) Done Line 322: data_in_mrs = false; > I don't think you should reset data_in_mrs, because it won't _remove_ data Thanks, this helped quite a bit. Hopefully the updated patch will be correct. Line 324: exists[row_key] = true; > you could just set this unconditionally Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/tablet/tablet-test-base.h File src/kudu/tablet/tablet-test-base.h: PS8, Line 328: int64_t count, : int32_t val, : TimeSeries *ts = NULL) { : > nit: indent Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: Line 620: > nit extra line Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: PS8, Line 408: default > seems it would be safer to explicitly do a 'case INSERT' here, and then hav Done Line 438: default: > same Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: PS8, Line 34: insert ignored > yea, this isn't a very clear description. I agree the count should be the n Done PS8, Line 34: insert ignored > Maybe this should be counting the number of errors that were ignored instea Done http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/tablet/transactions/transaction.h File src/kudu/tablet/transactions/transaction.h: Line 49: int successful_insert_ignores; > does what I mentioned in the tablet metrics apply here? Done -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Brock Noland <br...@phdata.io> Gerrit-Reviewer: Brock Noland <br...@phdata.io> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
