Todd Lipcon has posted comments on this change. Change subject: consensus: move more logic from ReplicaState to RaftConsensus ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4709/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 2063: // NOTE: the ReplicaState lock is held here because this is triggered by > Thanks for this comment. I think it would also be helpful to mention this i would rather not add it in ConsensusRound::NotifyReplicationFinished, because other implementors (ie the tablet) shouldn't care about the fact that they are holding a consensus-internal lock. Will add to NonTxRoundReplicationFinished, though. http://gerrit.cloudera.org:8080/#/c/4709/3/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: PS3, Line 405: Handle > this wording is confusing. does this mean that it was replicated or committ Done. Part of the confusion here is that, throughout consensus, we are a little fuzzy on the term 'replicated' vs 'committed'. Tried to clarify in the comments here. PS3, Line 427: but first check for : // and handle any consensus-related operations > what operations does this refer to? what is this "handling"? Done http://gerrit.cloudera.org:8080/#/c/4709/3/src/kudu/consensus/raft_consensus_state.cc File src/kudu/consensus/raft_consensus_state.cc: Line 510: > extra line Done -- To view, visit http://gerrit.cloudera.org:8080/4709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f377ebb132f3f58f984605197831f41198d78c5 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
