Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing ......................................................................
Patch Set 1: > haven't looked at the code yet, but a couple quick thoughts: > - let's make sure the trace buffer is bounded, so that if we have > some sort of tight loop retry bug we don't just make the user app > OOME Will do, right now it's unlimited. > - probably worth doing a sanity check of perf using YCSB or > something to make sure the tracing isn't costing too much (I think > a few percent is fine, but if it's a lot we should look at > optimizations before committing) Planning on doing that! -- To view, visit http://gerrit.cloudera.org:8080/4781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69ef56acc071b9f80b34e38c1821df4096f54907 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
