Alexey Serbin has posted comments on this change. Change subject: rpc: support GSSAPI authentication ......................................................................
Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/rpc/sasl_helper.cc File src/kudu/rpc/sasl_helper.cc: PS3, Line 50: plain_enabled_(false), : gssapi_enabled_(false) Aren't they mutually exclusive? http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: Line 26: #include <stdlib.h> nit: by google style guide, this should come before c++ standard headers (or make it <cstdlib> and add into the c++ standard headers group). https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes PS3, Line 64: std::function Does it need #include <functional> ? PS3, Line 196: CHECK ASSERT_TRUE() hear and below instead of CHECK() ? PS3, Line 201: CHECK_GT ASSERT_GT() here and below instead of CHECK_GT() ? PS3, Line 236: CHECK_OK ASSERT_OK() here and below instead of CHECK_OK() ? http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: Line 25: #include <stdlib.h> nit: please either convert into <cstdlib> or move up before C++ headers set. PS3, Line 328: Status MiniKdc::SetKrb5Environment() const specifier? PS3, Line 329: if (!kdc_process_) { : return Status::IllegalState("KDC not started"); : } So, it's necessary to set these after KDC has been started already? Are we sure it does not lead to any inconsistency? -- To view, visit http://gerrit.cloudera.org:8080/4763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1b93045acd428ef3437597059c5106b03e25d0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
