Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1691 - [python] Replaced group varint encoding with 
bitshuffle
......................................................................


Patch Set 2:

(3 comments)

Good work greg, just some small things. Thanks for the patch

http://gerrit.cloudera.org:8080/#/c/4824/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Replaced group varint encoding with bitshuffle
Nit: Maybe a more appropriate title? maybe: Updated column encoding options, or 
something


http://gerrit.cloudera.org:8080/#/c/4824/2/python/kudu/tests/test_schema.py
File python/kudu/tests/test_schema.py:

PS2, Line 126: ['auto', 'plain', 'prefix', 'bitshuffle',
             :                                'rle', 'dict']
Maybe swap in one of the enums here just for good measure?  kudu.ENCODING_DICT 
or w/e.


Line 131:             del foo
> I don't think you need to delete foo, do you? also could you make sure the 
See the todo below from wes, its currently not possible to confirm that this is 
set via the C++ api.


-- 
To view, visit http://gerrit.cloudera.org:8080/4824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18a611e746d48879d6e9988abcee42e0354dcfdc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: g.kocu...@gmail.com
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to