Alexey Serbin has posted comments on this change. Change subject: rpc: improve error messages and logging for bad authentication ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/4764/4/src/kudu/rpc/sasl_client.h File src/kudu/rpc/sasl_client.h: PS4, Line 135: Incopmlete nit: typo http://gerrit.cloudera.org:8080/#/c/4764/4/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: PS4, Line 34: #include "kudu/util/scoped_cleanup.h" nit: not sure whether this header is necessary here. PS4, Line 198: re What about calling regfree()? Is LSAN happy without that? PS4, Line 249: Status::NotAuthorized Does it make sense to return something else here instead? I.e., there might be SASL_FAILURE or SASL_BADPARAM errors, but why do we want to always map them into NotAuthorized()? Or it's not possible in this context? I think it's worth consider mapping the rest of error codes into something else at least to distinguish from the previous switch case (i.e., something like RunTimeError() or alike). http://gerrit.cloudera.org:8080/#/c/4764/4/src/kudu/rpc/sasl_server.cc File src/kudu/rpc/sasl_server.cc: PS4, Line 450: SaslMessagePB msg That might be not relevant to the scope of this patch, but it seems this variable is not used. -- To view, visit http://gerrit.cloudera.org:8080/4764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5156b09fa4f8c7591f4e399ce8cc450c089e88 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
