Will Berkeley has posted comments on this change. Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4795/2//COMMIT_MSG Commit Message: PS2, Line 10: capbility nit: sp http://gerrit.cloudera.org:8080/#/c/4795/2/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: PS2, Line 136: {'key': 10} I'm wondering what happens if one sets invalid column names or wrongly typed values in the splits or bounds, and also more generally in PartialRows constructed from list/tuple/dict. Here, it would catch it when create_table is executed if the bounds or splits are specified as list/tuple/dict, right? Are there any tests for what happens in these kinds of cases? This comment might belong in the PartialRow usability patch... -- To view, visit http://gerrit.cloudera.org:8080/4795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
