Dinesh Bhat has posted comments on this change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4852/2/src/kudu/scripts/jira_updater.py File src/kudu/scripts/jira_updater.py: PS2, Line 51: re.search(r'\bKUDU-[0-9] > Maybe this is too coarse. If the log output has a substring like That's a good point, yeah perhaps we can only check if the commit_msg starts with KUDU-[0-9]+, and ignore otherwise. I also don't have clarity on where do we want to place this script at this point - may be 'Code Review' can be be part of post-push script for gerrit ? and SHA log can be updated as part of pre-push to apache/kudu github repo ? Thanks for rev comments earlier, I will be addressing them shortly. -- To view, visit http://gerrit.cloudera.org:8080/4852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4519ee0b83f9af03ba55f0eacc0553e86a3f13ec Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
