Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL ......................................................................
Patch Set 5: (2 comments) Should I convert all the C-style casts in the ported code to C++ style casts? http://gerrit.cloudera.org:8080/#/c/4789/5/src/kudu/util/net/ssl_factory.h File src/kudu/util/net/ssl_factory.h: Line 70: } else { > warning: don't use else after return [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/4789/5/src/kudu/util/net/ssl_socket.cc File src/kudu/util/net/ssl_socket.cc: Line 87: } else if (match < 0) { > warning: don't use else after return [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/4789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27167faa4e6a78e59b46093055b16682c93af0ea Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
