Todd Lipcon has posted comments on this change.

Change subject: Fix SASL mechanism negotiation on the server side
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4875/1//COMMIT_MSG
Commit Message:

PS1, Line 9: intiialized
> nit: typo intiialized --> initialized
Done


http://gerrit.cloudera.org:8080/#/c/4875/1/src/kudu/rpc/sasl_rpc-test.cc
File src/kudu/rpc/sasl_rpc-test.cc:

PS1, Line 211:         CHECK_OK(sasl_client.EnablePlain("foo", "bar"));
             :         CHECK_OK(sasl_client.EnableGSSAPI());
> What happens if GSSAPI is not enabled on the client side, having just plain
i.e a test where client has PLAIN only, and the server has GSSAPI only? sure, 
can add that.


-- 
To view, visit http://gerrit.cloudera.org:8080/4875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4741ce618525311258d5ba61dd85f6f4721caf66
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to