Will Berkeley has posted comments on this change. Change subject: [python] - Update kudu.connect to enable multi-master ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4883/4/python/kudu/tests/common.py File python/kudu/tests/common.py: PS4, Line 61: s = socket.socket() : s.bind(('', 0)) : master_ports.append(s.getsockname()[1 > This doesn't work because you need to know the host/port of every master at Good point! I looked more closely at the C++ code and for multimaster tests it actually gives the ports explicitly. For example, as 11010, 11011, 11012 in the master failover test. At some point in the future masters will be able to join or leave but I don't think that's possible without restarts now. I think we can use default ports, or keep it how you've done here-- up to you. PS4, Line 64: s.close() > normally this would be the case, but since we never started listening on th Kk sounds good -- To view, visit http://gerrit.cloudera.org:8080/4883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2721236d5f92ced2afb4a867511c4144a2ab16a Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
