Jordan Birdsell has posted comments on this change. Change subject: KUDU-1638 - [python] Add Alter Table Support ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/4823/3/python/kudu/client.pyx File python/kudu/client.pyx: Line 2321: value = value.encode('utf8') > I don't see any case where _own isn't true Started adding this out of habit, removed. PS3, Line 2348: > I don't think this kwarg is relevant, since you can't change the PKs of a t Done PS3, Line 2353: tion* op > is this equivalent to just passing 'default=' kwarg? Yep, updated the comment to reflect both options. Line 2364: > see below Done Line 2367: self.applied = 1 > seems like it might be a pain to have to remember to update this doc if we Done -- To view, visit http://gerrit.cloudera.org:8080/4823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If72c76e1ea7c80452b401c55b19df4fbac7dd2d7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
