Adar Dembo has posted comments on this change. Change subject: block_manager: consolidate data directory management ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4793/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1179: return s; > Nit: this kinda assumes that container Open() failure is always followed by I disagree. Open() failures are fatal; all callers will use RETURN_NOT_OK() to surface them, eventually shutting down the process and cleaning up extant objects like these. To clean up here, I'd need to make the DataDirManager non-const and defer its construction from the LogBlockManager constructor out to here and to LogBlockManager::Create(), then use swap() to move it into the LBM state only if all opens succeeded. I don't think that's worth the complexity. A comment explaining this would either be non-visible (if it were here) or too distracting given the utility (if in the function header). -- To view, visit http://gerrit.cloudera.org:8080/4793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc9d8999117a6383e7487b6c5bf065f10247b1d7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
