Mike Percy has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) ......................................................................
Patch Set 10: (2 comments) > Would you mind also adding a test that makes sure that attempting > to copy over an existing (running) tablet, even in --force mode, > fails? Forget this comment, after looking at the code it would not fail, it would actually tombstone the existing one and then overwrite it. http://gerrit.cloudera.org:8080/#/c/4834/10/src/kudu/tools/tool_action_remote_replica.cc File src/kudu/tools/tool_action_remote_replica.cc: Line 52: DEFINE_bool(force_copy, false, Hmm, can we just make this --force instead of --force_copy ? --force seems a lot easier to remember. Line 320: } I think by default we should pass in the source server's term. This can be obtained via the consensus_proxy->GetConsensusState() call. If we don't do this, people will have to just use --force all of the time which seems silly. -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113a25e9b6c14f7c3814140917b61e35030b58d0 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
