Alexey Serbin has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4945/2//COMMIT_MSG Commit Message: PS2, Line 9: nit: an extra space http://gerrit.cloudera.org:8080/#/c/4945/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS2, Line 3932: nit: per the styling guide, the indent is 2 spaces. PS2, Line 3939: even replication nit: even replication factor? http://gerrit.cloudera.org:8080/#/c/4945/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2, Line 119: "" It would be nice to have a short description for this flag. PS2, Line 120: TAG_FLAG(allow_unsafe_replication_factor Does it make sense to mark it as advanced as well? PS2, Line 884: style: per current style guide, the regular indent is 2 spaces; do not use tabs. -- To view, visit http://gerrit.cloudera.org:8080/4945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
