Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4992

to review the following change.

Change subject: rpc: fix too-long memcmp for HTTP methods
......................................................................

rpc: fix too-long memcmp for HTTP methods

Previously we were using arraysize(kHTTPHeader) where kHTTPHeader is a
constant "HTTP". This array would then include the terminating null
byte, which is length 5 rather than the expected length 4.

This switches to using strlen.

Change-Id: Ic3f7be076bf0e1459d583876f65036e31034adcb
---
M src/kudu/rpc/blocking_ops.cc
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/4992/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3f7be076bf0e1459d583876f65036e31034adcb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>

Reply via email to