David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1735. Fix crash when aborting a skipped config change round ......................................................................
Patch Set 3: Code-Review+2 (2 comments) Just nits. ignore/don't ignore, you choose :) http://gerrit.cloudera.org:8080/#/c/4916/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS2, Line 610: -> man that's a lot of arrows. maybe we could just get the mutable pointer below? http://gerrit.cloudera.org:8080/#/c/4916/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS3, Line 619: const RaftConfigPB& new_config = change_record.new_config(); I forget: do we have checks somewhere that the new config has a higher term and/or index? should we? -- To view, visit http://gerrit.cloudera.org:8080/4916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b4e4eb1d60ef66527edf33357fabc22f4b5b32f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
